[enhancement] #62 - Provide link towards created issue #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mdeloupy
changed the title
mdeloupy
force-pushed
the
enhancement-md-62-provide-issue-link
branch
from
418a514
to
0ce58c3
Compare
1 similar comment
|
@benichu Ready for review |
benichu
requested changes
Oct 6, 2016
| @@ -180,7 +180,8 @@ command :new do |c| | |||
| puts " to the project: #{project[:name]}" | |||
| parsed_checklist = Checklister::Parser.new(checklist_path, title) | |||
| issue = api_client.issue.create(project_id, parsed_checklist.to_params) | |||
| puts "* Issue successfully created!" | |||
| issue_url = issue.url || issue.web_url | |||
There was a problem hiding this comment.
If url is a property from the github response, can you find out if html_url is available? https://developer.github.com/v3/issues/#response-3
Because it looks like url returns the api.github.com domain (JSON response) instead of just github.com (HTML response)
There was a problem hiding this comment.
You're definitely right, I changed it.
mdeloupy
force-pushed
the
enhancement-md-62-provide-issue-link
branch
from
80bcfaa
to
5e4c6ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.