Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics to monitor Redis connections #22

Merged
merged 2 commits into from
Feb 23, 2016

Conversation

vivekkothari
Copy link

To Fix
Metrics for Jedis Pool #21

benjamin-bader added a commit that referenced this pull request Feb 23, 2016
Add metrics to monitor Redis connections
@benjamin-bader benjamin-bader merged commit b76d061 into benjamin-bader:master Feb 23, 2016
@benjamin-bader
Copy link
Owner

Awesome, thank you!

@vivekkothari
Copy link
Author

can you release it to maven central?

@benjamin-bader
Copy link
Owner

Yes, but it will have to wait until later this week - I've switched machines since the last release, and need to re-discover some Maven incantations that will get it done. For now though, it's bedtime here in California.

Thanks again for your contribution!

@benjamin-bader
Copy link
Owner

Version 0.9.1-1 has been pushed to Maven Central, and should be available within an hour or so.

@vivekkothari
Copy link
Author

There seems to be something wrong with the artifact on Maven.
http://mvnrepository.com/artifact/com.bendb.dropwizard/dropwizard-redis/0.9.1-1
Also It does't have my changes. Can you please check?

@benjamin-bader
Copy link
Owner

I downloaded and decompiled the jar from the link you posted, and the extra metrics you added in this PR are definitely there. Are you sure that you're pulling the new version into your project?

What other problem are you seeing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants