PDB rewriting, take 2

benjamin-hodgson · Dec 14, 2018 · 998700b · 998700b
1 parent 08936ec
commit 998700b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/Pidgin.DllRewriter/Program.cs b/Pidgin.DllRewriter/Program.cs
@@ -14,14 +14,14 @@ static void Main(string[] args)
         {
             var netcoreapp = args[0].StartsWith("netcoreapp");
 
-            var module = ModuleDefinition.ReadModule(args[1], new ReaderParameters { ReadSymbols = true });
+            var module = ModuleDefinition.ReadModule(args[1], new ReaderParameters { ReadSymbols = true, InMemory = true });
 
             var unsafeType = module.Types.Single(t => t.Name == "Unsafe");
 
             RewriteAsPointerMethod(unsafeType);
             RewriteAsRefMethod(netcoreapp, unsafeType, module.TypeSystem);
 
-            module.Write(args[2], new WriterParameters { WriteSymbols = true });
+            module.Write(args[1], new WriterParameters { WriteSymbols = true });
         }
 
         // https://github.com/dotnet/corefx/blob/7942e7c3ed03cf7f19dffe539e23b84b4a85ad5a/src/System.Runtime.CompilerServices.Unsafe/src/System.Runtime.CompilerServices.Unsafe.il#L145

diff --git a/Pidgin/Pidgin.csproj b/Pidgin/Pidgin.csproj
@@ -34,9 +34,7 @@
   </ItemGroup>
 
   <Target Name="RewriteDll" AfterTargets="AfterBuild">
-    <Exec Command="dotnet run --project &quot;$(MSBuildProjectDirectory)/../Pidgin.DllRewriter&quot; &quot;$(TargetFramework)&quot; &quot;$(MSBuildProjectDirectory)/$(OutputPath)Pidgin.dll&quot; &quot;$(MSBuildProjectDirectory)/$(OutputPath)Pidgin_Rewritten.dll&quot;" />
-    <Copy SourceFiles="$(OutputPath)Pidgin_Rewritten.dll;$(OutputPath)Pidgin_Rewritten.pdb" DestinationFiles="$(OutputPath)Pidgin.dll;$(OutputPath)Pidgin.pdb" />
-    <Delete Files="$(OutputPath)Pidgin_Rewritten.dll;$(OutputPath)Pidgin_Rewritten.pdb" />
+    <Exec Command="dotnet run --project &quot;$(MSBuildProjectDirectory)/../Pidgin.DllRewriter&quot; &quot;$(TargetFramework)&quot; &quot;$(MSBuildProjectDirectory)/$(OutputPath)Pidgin.dll&quot;" />
   </Target>
 
 </Project>