Unusual input returns a 404 #1

Closed
binhums opened this Issue Apr 16, 2013 · 2 comments

Projects

None yet

2 participants

@binhums
binhums commented Apr 16, 2013

Inputting erroneous input such as https://www.google.co.uk/ returns a 404 with no description.

sundial404

Although this isn't a specific use case I had copied a pasted a number of the format

123/456-7890

And this also returned the same page.

@benjaminasmith
Owner

Thanks for the report.

It looks as if URI::encode does not percent-encode / to %2F. We'll need a more robust escaping/encoding solution in lib/sundial.rb. I'll fix this later on.

@benjaminasmith
Owner

Fixed on master in 4ea7384.

The fix has been deployed to (my live hosted copy)[http://sundial.benjaminasmith.com], too.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment