Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unusual input returns a 404 #1

Closed
ghost opened this issue Apr 16, 2013 · 2 comments
Closed

Unusual input returns a 404 #1

ghost opened this issue Apr 16, 2013 · 2 comments
Assignees
Labels

Comments

@ghost
Copy link

ghost commented Apr 16, 2013

Inputting erroneous input such as https://www.google.co.uk/ returns a 404 with no description.

sundial404

Although this isn't a specific use case I had copied a pasted a number of the format

123/456-7890

And this also returned the same page.

@ghost ghost assigned benbarbersmith Apr 16, 2013
@benbarbersmith
Copy link
Owner

Thanks for the report.

It looks as if URI::encode does not percent-encode / to %2F. We'll need a more robust escaping/encoding solution in lib/sundial.rb. I'll fix this later on.

@benbarbersmith
Copy link
Owner

Fixed on master in 4ea7384.

The fix has been deployed to (my live hosted copy)[http://sundial.benjaminasmith.com], too.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant