Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple galleries not working #25

Closed
maxGross opened this issue Mar 8, 2017 · 6 comments
Closed

Multiple galleries not working #25

maxGross opened this issue Mar 8, 2017 · 6 comments

Comments

@maxGross
Copy link

maxGross commented Mar 8, 2017

Error when using several gallery names @f14424b46d2f33f6366db0cc790aa2e471f8e975

e.g. [galleryName]="myGallery"
Console output tells following error:

404 Not Found for URL: http://localhost:4200/assets/img/gallery/undefined/data.json

  • Images are provided at the local file structure
  • Using the gallery with default root path for all images works fine.
@maxGross
Copy link
Author

maxGross commented Mar 8, 2017

my fault ...
works great!

@maxGross maxGross closed this as completed Mar 8, 2017
@stefan-frank
Copy link

What was your fault? It seems someone else and me are making the same fault as well...

@maxGross
Copy link
Author

I used the @input() variable like this: [galleryName]="galleryName"
My assumption was that this will refer to the the gallery folder named galleryName. But of course this won't work cause angular will look for a variable named galleryName!
So i declared a variable galleryName = "myGalleryFolder" and it works.

@stefan-frank
Copy link

Thanks for your explanation. It works for me as well. The documentation might be enhanced to prevent further misunderstandings.

@rustygreen
Copy link

Just to note, you could do it without declaring a variable (like you were trying to originally), but you'd have to put quotes around the gallery name: [galleryName]="'galleryName'"

@BenjaminBrandmeier
Copy link
Owner

I changed the README to include the single quotes, since this looks more intuitive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants