Skip to content
This repository has been archived by the owner on Sep 6, 2024. It is now read-only.

[Drawer] Missing animation when closing programatically #54

Closed
benjamincanac opened this issue Apr 11, 2024 · 6 comments
Closed

[Drawer] Missing animation when closing programatically #54

benjamincanac opened this issue Apr 11, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@benjamincanac
Copy link
Owner

benjamincanac commented Apr 11, 2024

unovue/vaul-vue#33

@benjamincanac benjamincanac added the bug Something isn't working label Apr 11, 2024
@robin-dongbin
Copy link

I think we should build this by ourself, based on radix-ui dialog

@robin-dongbin
Copy link

I saw we have a Slideover component already, what is diffrent with Drawer?

@benjamincanac
Copy link
Owner Author

The vaul-vue repository is part of Radix Vue, I don't see why we wouldn't use the available primitives, it works well 😊

@robin-dongbin
Copy link

I don't think we need this, I think we should rename Slideover to Drawer

@Saeid-Za
Copy link

Better to be based on a unified ecosystem!
Although I tried to find a solution when I first encountered the issue, I'll try again.

@robin-dongbin
Copy link

robin-dongbin commented Apr 14, 2024

Since I checked this component, it seems to be a parody IOS component built specifically for mobile, which is not the same as a component in a Drawer in most component libraries.

Instead, the Silderover component looks like a Drawer in most component libraries

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants