Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Directive should work with no options passed in #29

Closed
benjamincharity opened this issue Mar 6, 2016 · 3 comments
Closed

Directive should work with no options passed in #29

benjamincharity opened this issue Mar 6, 2016 · 3 comments
Assignees
@benjamincharity
Labels
Priority: High Type: Bug

Comments

@benjamincharity
Copy link
Owner

Currently the directive chokes if it doesn't receive an object.
@benjamincharity benjamincharity self-assigned this Mar 6, 2016
@diegopamio
Copy link

I still get "Unexpected end of JSON input " when no options are provided.

@benjamincharity
Copy link
Owner Author

Thanks for calling this out @diegopamio, I was able to reproduce so I am reopening. Should be a quick fix so I'll try to get to it after work 👍

@benjamincharity
Copy link
Owner Author

Fixed in 2.0.1: https://github.com/benjamincharity/angular-flickity/releases/tag/v2.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benjamincharity benjamincharity

Labels
Priority: High Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benjamincharity @diegopamio