Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies seem to be misconfigured #8

Closed
zumwald opened this issue Sep 16, 2016 · 3 comments
Closed

Dependencies seem to be misconfigured #8

zumwald opened this issue Sep 16, 2016 · 3 comments
Assignees

Comments

@zumwald
Copy link

zumwald commented Sep 16, 2016

webpack-dev-server is only for development use, so it should be a dev-dependency rather than a full blown dependency. This is causing npm install errors in CI because we don't want to package webpack-dev-server with our product.

On that note, the readme mentions Angular 1.4.0+ as a dependency, but Angular only included as a dev-dependency at version 1.5.8+.

Cleaning up the dependencies would be much appreciated!

@zumwald zumwald closed this as completed Sep 16, 2016
@zumwald zumwald reopened this Sep 16, 2016
@benjamincharity
Copy link
Owner

benjamincharity commented Sep 19, 2016

Thanks for pointing this out @zumwald! Apparently I was a little too focused on getting 2.0 out and I missed a few housekeeping opportunities.

  • Move webpack-dev-server to devDependencies.
  • Move AngularJS to dependencies.
    • Add version ^1.4.0 to allow AngularJS from 1.4.0 to any 1.x.x.

@benjamincharity
Copy link
Owner

@zumwald
Copy link
Author

zumwald commented Sep 19, 2016

Thanks @benjamincharity !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants