Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A11y Code Sprint Berlin: Success Criterion 9.2.4.6 - remove redundant fieldsets from forms #1304

Closed
SarahEdding opened this issue May 31, 2023 · 4 comments

Comments

@SarahEdding
Copy link
Collaborator

SarahEdding commented May 31, 2023

Feature Request

Description

In the contact form, fields are currently grouped into two fieldsets, neither of which is labelled. This is based on the form's layout and is confusing to screen reader users, because the grouping is not related to structure and/or content of the form.
Fieldset in login form is also redundant.

Solution

Removing both fieldsets will result in a concise and clear contact form that is structured in a way users are accustomed to.

Alternative

If removing the fieldsets is not possible, adding legends to both of them may help users to understand the form better.

@SarahEdding SarahEdding changed the title A11y Code Sprint Berlin: Success Criterion 9.2.4.6 - remove fieldset from contact form A11y Code Sprint Berlin: Success Criterion 9.2.4.6 - remove redundant fieldsets from forms Jun 1, 2023
@schmigotzki
Copy link
Contributor

@alexakressmann Please assign to me

@schmigotzki
Copy link
Contributor

schmigotzki commented Jun 6, 2023

@SarahEdding How about this solution?
Adding a label (/legend) to each fieldset would be easier.

form markup

@schmigotzki
Copy link
Contributor

Fieldsets in the felogin forms are unnecessary and could be removed. This is not optimal from an accessibility point of view, but according to @SarahEdding it can be tolerated. This would be a core change and can be implemented on occasion.

@alexakressmann alexakressmann moved this from In progress to QA in Code Sprint A11Y Certification Jun 9, 2023
@benjaminkott benjaminkott moved this from Merge, Deploy & QA to Calendar Week 24 in Code Sprint A11Y Certification Jun 13, 2023
benjaminkott added a commit that referenced this issue Jun 14, 2023
@benjaminkott
Copy link
Owner

We introduce a new element that needs to be used to avoid fieldsets. The form served by the bootstrap_package is already adjusted. If the introduction package uses a different one the fieldset needs to be replaced with grid column.

See change here: 9132b04#diff-a51f3921d8ba07c03befce1d404f530f7a8991d3d59df8d52d5ea6e88d823e63

@benjaminkott benjaminkott moved this from Calendar Week 24 to Merge, Deploy & QA in Code Sprint A11Y Certification Jun 14, 2023
@benjaminkott benjaminkott added QA and removed feature labels Jun 14, 2023
Code Sprint A11Y Certification automation moved this from Merge, Deploy & QA to Done Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 participants