Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A11y Code Sprint Berlin: Success Criterion 9.1.3.1a - Info and Relationships - Headings in Cookie Consent Banner #1320

Closed
alexakressmann opened this issue Jun 1, 2023 · 2 comments
Closed

A11y Code Sprint Berlin: Success Criterion 9.1.3.1a - Info and Relationships - Headings in Cookie Consent Banner #1320

alexakressmann opened this issue Jun 1, 2023 · 2 comments
Assignees
@alexakressmann @SarahEdding
Labels
QA
Projects
Code Sprint A11Y Certification

Comments

@alexakressmann
Copy link
Collaborator

alexakressmann commented Jun 1, 2023 •
edited

Page

Cookie Consent Banner (Please open any page in private tab to see it)

Description

All headings need to be marked as headings in correct order.
To WCAG

Solution

Add visible heading level H2 in the cookie consent banner: "We use cookies"

Context, links and screenshots

Cookie-Banner-2023-05-30 15_33_52-Congratulations
Cookie-Banner-Schrift markiert-2023-05-30 15_33_52-Congratulations
@benjaminkott benjaminkott moved this from To do to In progress in Code Sprint A11Y Certification Jun 5, 2023
Starkmann added a commit to Starkmann/bootstrap_package that referenced this issue Jun 5, 2023
@Starkmann
[TASK] overwrite default cookie consent configuration
8f9d8b4 
Change span to h2 in header and remove aria-live="polite" from dialog
Also change header text

Ref: benjaminkott#1313, benjaminkott#1320
Starkmann added a commit to Starkmann/bootstrap_package that referenced this issue Jun 5, 2023
@Starkmann
[TASK] resize cookiee consent header to 1.5rem
7ecf6ed 
Ref: benjaminkott#1320
@Starkmann Starkmann mentioned this issue Jun 5, 2023
Closed
2 tasks
benjaminkott pushed a commit that referenced this issue Jun 5, 2023
@Starkmann @benjaminkott
[TASK] Overwrite default cookie consent configuration
84158b7 
Change span to h2 in header and remove aria-live="polite" from dialog
Also change header text

Ref: #1313, #1320
benjaminkott pushed a commit that referenced this issue Jun 5, 2023
@Starkmann @benjaminkott
[TASK] Resize cookiee consent header to 1.5rem
34c6b0e 
Ref: #1320
Starkmann added a commit to Starkmann/bootstrap_package that referenced this issue Jun 6, 2023
@Starkmann
[TASK] overwrite default cookie consent configuration
e8b6880 
Change span to h2 in header and remove aria-live="polite" from dialog
Also change header text

Ref: benjaminkott#1313, benjaminkott#1320
Starkmann added a commit to Starkmann/bootstrap_package that referenced this issue Jun 6, 2023
@Starkmann
[TASK] resize cookiee consent header to 1.5rem
c0d98bc 
Ref: benjaminkott#1320
eliashaeussler added a commit to CPS-IT/bootstrap_package that referenced this issue Jun 8, 2023
@eliashaeussler
Merge remote-tracking branch 'Starkmann/feature/benjaminkott#1313-ben…
2ae5517 
…jaminkott#1320' into preview
@alexakressmann alexakressmann moved this from In progress to QA in Code Sprint A11Y Certification Jun 9, 2023
@alexakressmann alexakressmann self-assigned this Jun 9, 2023
@benjaminkott benjaminkott moved this from Merge, Deploy & QA to In progress in Code Sprint A11Y Certification Jun 13, 2023
benjaminkott added a commit that referenced this issue Jun 13, 2023
@benjaminkott
[TASK] Change default cookieconsent to include header
97cd552 
Relates: #1320
@benjaminkott benjaminkott moved this from In progress to Merge, Deploy & QA in Code Sprint A11Y Certification Jun 13, 2023
@benjaminkott benjaminkott added QA and removed feature labels Jun 13, 2023
@SarahEdding
Copy link
Collaborator

H2 is there, but is the first heading in DOM. We have to make sure, thats okay.

@SarahEdding SarahEdding moved this from Merge, Deploy & QA to To do in Code Sprint A11Y Certification Jun 14, 2023
@SarahEdding
Copy link
Collaborator

H2 is alright in this case.

Code Sprint A11Y Certification automation moved this from To do to Done Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexakressmann alexakressmann

@SarahEdding SarahEdding

Labels
QA
Projects
Code Sprint A11Y Certification
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/#1313 #1320 Starkmann/bootstrap_package
3 participants
@benjaminkott @alexakressmann @SarahEdding