With gc disabled deletion of class X causes it to "leak" to garbage #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you be more specific about what the problem is? |
|
Yes, it goes to gc.garbage. Since we run our environment with gc disabled we monitor garbage during development to make sure we don't leak anything. This causes our automated alert to trigger. Thanks. |
|
@benjaminp any update here? |
jeffwidman
added a commit
to dpkp/kafka-python
that referenced
this pull request
Oct 22, 2018
Bump `six` to `1.11.0`. Most changes do not affect us, but it's good to stay up to date. Also, we will likely start vendoring `enum34` in which case benjaminp/six#178 is needed. Note that this preserves the `kafka-python` customization from #979 which has been submitted upstream as benjaminp/six#176 but not yet merged.
jeffwidman
added a commit
to dpkp/kafka-python
that referenced
this pull request
Oct 22, 2018
Bump `six` to `1.11.0`. Most changes do not affect us, but it's good to stay up to date. Also, we will likely start vendoring `enum34` in which case benjaminp/six#178 is needed. Note that this preserves the `kafka-python` customization from #979 which has been submitted upstream as benjaminp/six#176 but not yet merged.
jeffwidman
added a commit
to dpkp/kafka-python
that referenced
this pull request
Oct 22, 2018
Bump `six` to `1.11.0`. Most changes do not affect us, but it's good to stay up to date. Also, we will likely start vendoring `enum34` in which case benjaminp/six#178 is needed. Note that this preserves the `kafka-python` customization from #979 which has been submitted upstream as benjaminp/six#176 but not yet merged.
|
To avoid a |
shifqu
added a commit
to shifqu/kafka-python
that referenced
this pull request
Sep 28, 2023
In this commit, the del X is still commented out due to the fact that upstream benjaminp/six#176 is not merged.
wbarnha
pushed a commit
to dpkp/kafka-python
that referenced
this pull request
Nov 2, 2023
In this commit, the del X is still commented out due to the fact that upstream benjaminp/six#176 is not merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.