Wrong means, medians

[oleksii-nikolaienko]

Hi,
I get a very strange output for means, medians and max values in this example:

table1::table1(~ x | y, data.frame(x=c(2000:2009), y="Y"))

While the following works correctly:

table1::table1(~ x | y, data.frame(x=c(0:9), y="Y"))

It seems to have something to do with rounding when I try to use other ranges of x: c(10, 19), c(100, 109), c(1000, 1009).
I think the output is very wrong when it comes to years (as I have in the first example)

[benjaminrich]

Please have a look at #24.

There is nothing wrong with the calculations, just increase the number of significant digits to 5 (default is 3).

table1::table1(~ x | y, data.frame(x=c(2000:2009), y="Y"), digits=5)

(Aside: While it seems strange to me that you would want to take the the mean of calendar years, I guess you know what you are doing)

[oleksii-nikolaienko]

Yes, sorry for that, I didn't know default value for digits=3. Can see it specified in signif_pad(), but not in table1().
On my issue: in this case I wanted to know median and min/max, and instead of 2005 [2001, 2009] got 2010 [2000, 2010]. And pasted it right into my manuscript without checking with summary(). So while I understand that there is no bug here, it is still a bit misleading, especially given the different default for number of digits... Made me think how many times I could make the same mistake before...

[oleksii-nikolaienko]

I get your point on the default values, but some people get confused. Would it be possible to specifically explain this better in the table1() help page?

[benjaminrich]

Thanks. I will take in under consideration for the next release.