Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement require("ast-types").astNodesAreEquivalent for reliably testing deep equivalence of nodes #46

Closed
benjamn opened this issue Jul 15, 2014 · 1 comment · Fixed by #47
Closed

Implement require("ast-types").astNodesAreEquivalent for reliably testing deep equivalence of nodes #46

benjamn opened this issue Jul 15, 2014 · 1 comment · Fixed by #47
Labels
enhancement

Comments

@benjamn
Copy link
Owner

benjamn commented Jul 15, 2014

This logic gets rewritten in most code bases that operate on ASTs, and would be very useful for testing transforms.

cc @thedekel @jeffmo
@jeffmo
Copy link
Contributor

jeffmo commented Jul 15, 2014

+1

benjamn added a commit that referenced this issue Jul 16, 2014
@benjamn
Implement require("ast-types").astNodesAreEquivalent.
3d1a95b 
The most interesting bit is the optional path tracking to improve
astNodesAreEquivalent.assert error messages.

Closes #46.
@benjamn benjamn mentioned this issue Jul 16, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement require("ast-types").astNodesAreEquivalent. benjamn/ast-types
2 participants
@benjamn @jeffmo