New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make forkable #145
Make forkable #145
Conversation
Thanks for this @jamestalmage! If we're going to change all that whitespace anyway, I would really love to finally switch to using two spaces per tab for indentation. Would that be easy to fix? |
I would think so. I will update soon. |
@jamestalmage Can you update with what needs to be done here? Looks like we would need this to progress on babel/babel#3561 to account for babel 6 node types |
30ac354
to
f7f40e0
Compare
e484852
to
d3b32c0
Compare
Rebased, and eliminated some irrelevant style-only changes that were cluttering the diff: Best viewed via https://github.com/benjamn/ast-types/pull/145/files?w=1 @benjamn - I never did change to two tab spaces, but now I am concerned doing so would create headaches for @hzoo rebasing #162 once this is merged. Would you prefer I hold off on the whitespace changes for now? @hzoo? |
Might make it easier to read but you can always use |
Thanks again @jamestalmage, especially for your patience. 🍴 🎉 |
🎉 happy this made it in! |
The minor version bump is due to the significant code changes involved in #145, even though no behavioral changes are expected.
My attempt at fixing #57.
Fully customizable definitions can now be achieved:
One potential downside (and I don't see it being a big deal):