Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add definitions for Flow's IndexedAccessType #514

Merged
merged 2 commits into from
Nov 28, 2021
Merged

Add definitions for Flow's IndexedAccessType #514

merged 2 commits into from
Nov 28, 2021

Conversation

gkz
Copy link
Contributor

@gkz gkz commented Mar 25, 2021 •
edited
Loading

This adds definitions for Flow's IndexedAccessType type annotation. This has been a part of Flow since Flow 0.146

Also adds definitions for Flow's OptionalIndexedAccessType type annotation.

Tested with npm test

@gkz
Copy link
Contributor Author

gkz commented Jul 6, 2021

Hi @benjamn! :)
I was wondering if it would be possible to take a look at this PR - it just affects Flow's type definitions, and just adds definitions (does not modify any existing ones), so is backwards compatible.
Thanks!

@christianvuerings
Copy link

@benjamn could you take a look at this PR and release a new version of ast-types when it's merged? Right now this blocks our Flow upgrade.

@benjamn benjamn self-assigned this Nov 28, 2021
benjamn
benjamn approved these changes Nov 28, 2021
View reviewed changes
Copy link
Owner

@benjamn benjamn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and sorry about the long wait @gkz!

Note: flow-parser will also be updated (from v0.132.0 to v0.164.0) in the next release, thanks to #651.

@benjamn benjamn merged commit a6cca55 into benjamn:master Nov 28, 2021
@pascalduez pascalduez mentioned this pull request Jan 20, 2022
Closed
@buschco buschco mentioned this pull request Mar 18, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamn benjamn benjamn approved these changes

Assignees

@benjamn benjamn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gkz @christianvuerings @benjamn