Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XJS -> JSX #93

Merged
merged 1 commit into from Mar 2, 2015
Merged

XJS -> JSX #93

merged 1 commit into from Mar 2, 2015

Conversation

fkling
Copy link
Contributor

@fkling fkling commented Mar 2, 2015

Closes #91. I did a simple search/replace. I don't think there is anything else to be done here?

@fkling
Copy link
Contributor Author

fkling commented Mar 2, 2015

We could also have definitions for both, XJS* and JSX* elements. That would allow consumers to use older esprima-fb versions. But I don't know if this is really valuable.

benjamn added a commit that referenced this pull request Mar 2, 2015
@benjamn benjamn merged commit 30227c7 into benjamn:master Mar 2, 2015
@benjamn
Copy link
Owner

benjamn commented Mar 2, 2015

Thanks! And yeah, I don't think anyone really depends on this part of the library.

@sebmck
Copy link
Contributor

sebmck commented Mar 3, 2015

@benjamn Any ETA on a release? Currently a blocker for babel/babel#930, thanks!

@benjamn
Copy link
Owner

benjamn commented Mar 3, 2015

I think this has to be a minor version bump, just in case anyone was using the XJS* types. Is that ok?

@fkling
Copy link
Contributor Author

fkling commented Mar 3, 2015

Sounds reasonable to me.

@benjamn
Copy link
Owner

benjamn commented Mar 3, 2015

Ok, published to NPM as v0.7.0: http://npmjs.org/package/ast-types

@sebmck
Copy link
Contributor

sebmck commented Mar 3, 2015

Thanks @benjamn!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XJS -> JSX
3 participants