Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support optimistic.forget to remove Entry objects from Cache. #84

Merged
merged 3 commits into from
Oct 13, 2020
Merged

Support optimistic.forget to remove Entry objects from Cache. #84

merged 3 commits into from
Oct 13, 2020

Commits on Oct 13, 2020

  1. Support optimistic.forget to remove entries from cache. 

    This method takes the same arguments that optimistic.dirty and
optimistic.peek take (TKeyArgs, as opposed to the full TArgs that the
optimistic function itself takes). This distinction means you can remove
entries as long as you have TKeyArgs, even if you don't have TArgs.

Like Map.prototype.delete and friends, optimistic.forget returns a boolean
to indicate whether an entry was deleted.
    @benjamn
    benjamn committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    d95e8e5 View commit details
    Browse the repository at this point in the history

  2. Tests for optimistic.forget.

    @benjamn
    benjamn committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    b3e354e View commit details
    Browse the repository at this point in the history

  3. Test optimistic.forget return values.

    @benjamn
    benjamn committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    2df4d9b View commit details
    Browse the repository at this point in the history