Can't exclude inner classes because Scala expects them to exist. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Properly changed all artifacts of rxjava-core to be rxjava-x.y.z.* * For Groovy/Clojure/JRuby/dynamic, moved dependency on rxjava-core to provided scope, as well as all tests * For Scala, left rxjava-core as compile scope, since rxjava-scala jar doesn't contain Observable (as constructed)
benjchristensen
pushed a commit
that referenced
this pull request
Sep 4, 2013
Zip and CombineLatest Operators: Generic Order and More Arities
benjchristensen
pushed a commit
that referenced
this pull request
Nov 5, 2013
We decided it's better to leave it to the caller when it's appropriate to release, cf. #1
headinthebox
added a commit
that referenced
this pull request
Dec 9, 2013
A few trivial Scala adaptor details
benjchristensen
pushed a commit
that referenced
this pull request
Dec 9, 2013
remove package rx.lang.scala.util since all its contents were removed
benjchristensen
pushed a commit
that referenced
this pull request
May 19, 2014
benjchristensen
pushed a commit
that referenced
this pull request
Nov 15, 2014
…javadoc description (ReactiveX#1847)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Scala, it's not so easy to exclude the unit tests from the published JARs, unfortunately. The Scala compiler expects specified inner classes to actually exist in libraries.
This means that all JARs in RxJava modules which might be used by Scala have to include all their inner classes. Currently, this just applies to
rxjava-swing, as far as I can see.This PR simply removes excluding the unit tests from
rxjava-swingfrom the Gradle build.