New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3 and PyPy fixes and some other minor cleanups #1
Conversation
Ping? |
On Thu, Apr 11, 2013 at 5:26 AM, Marius Gedminas
I'm still alive. I will try my best to look at your branch in the next 48 hours.Benji York |
I spent some time looking over the changes and I generally like what I see. I'm a little concerned about this output: RefactoringTool: Refactored build/src/tests/api_tests.txt
[snip several similar transformations] I can't find how how this is being invoked, or what it is even (I assume it is the 2to3 tool). I would rather make the code and tests work under both python 2 and 3 than have install-time transformations happening. Can you provide any insight on what is triggering this? |
Where do you see this output? There's no file named |
I've rebased my changes on top of the current master. Some clarification: nothing in manuel itself relies on 2to3. tox creates virtualenvs for each Python version (under .tox); virtualenv installs distribute when run under Python 3.x, distribute uses 2to3. To my knowledge that's the only place where 2to3 gets involved while testing manuel. (I expect soon we'll have virtualenv using setuptools 0.7, which AFAIK supports Python 3 natively, without using 2to3.) |
merged in 94303b4 |
No description provided.