Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test detection in Python 2. #21

Merged
merged 1 commit into from Aug 30, 2019
Merged

Fix test detection in Python 2. #21

merged 1 commit into from Aug 30, 2019

Conversation

icemac
Copy link

@icemac icemac commented Aug 23, 2019

Fixes #20.

@icemac
Copy link
Author

icemac commented Aug 23, 2019

cc @jamadden

mgedmin
mgedmin approved these changes Aug 23, 2019
View reviewed changes
Copy link

@mgedmin mgedmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG this bug is amazing

Python 2.7.16 (default, Apr  6 2019, 01:42:57) 
[GCC 8.3.0] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> "utf-8".encode()
'utf-8'

@icemac
Copy link
Author

icemac commented Aug 30, 2019

@benji-york Hi, could you please review and possibly merge this PR?

@benji-york
Copy link
Owner

Thanks for finding and fixing this!

If Python 2 weren't very nearly end-of-life, I would like a test that would have found this bug, but as-is I think it's fine.

@benji-york benji-york merged commit aeea5ce into benji-york:master Aug 30, 2019
@icemac
Copy link
Author

icemac commented Sep 3, 2019

@benji-york Thank you for merging the PR, may I ask for a release to PyPI, too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgedmin mgedmin mgedmin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Does not run tests on Python 2
3 participants
@icemac @benji-york @mgedmin