Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear Option Instruction #42

Open
lwb52 opened this issue Mar 18, 2021 · 2 comments
Open

Unclear Option Instruction #42

lwb52 opened this issue Mar 18, 2021 · 2 comments

Comments

@lwb52
Copy link

lwb52 commented Mar 18, 2021

In the option pane, the ”Unpin active tab behavior” item says that choosing to keep "the active tab selected (may replaces the temporary one)”—this is unclear – even if the extra ”s” is removed from ”replaces” – because there is no mention of what a ”temporary” tab might be…

@benji300
Copy link
Owner

Thanks for the hint @lwb52. What about the following version?

Specify the behavior when unpinning the current active tab. Either keep the active tab selected or select another one, depending on the setting. In case 'Keep selected' is set, the temporary tab (italic font) may be replaced with the current active tab.

The phrase "italic font" is already used in the description of "Add tab behavior".
But that's just an idea... I am open to suggestions.

benji300 added a commit that referenced this issue May 20, 2021
@wolcen
Copy link

wolcen commented May 31, 2021

It took me a minute to understand what (italic font) even meant above, but I get it now. Perhaps be specific, e.g.:

... Is case 'Keep selected' is set, the temporary tab (shown with italic font in the tab list) may be replaced...

I would actually suggest going a little further and adding something to the Usage section [of README.md] explaining how you start out with a "work"/temporary tab of sorts until it is pinned. Maybe the term could be adjusted (to e.g. "work", since "active" would be completely unclear)? I haven't used this long enough yet to make a strong recommendation.

🤷 otherwise, it takes a bit experimentation to understand how exactly this is working.

In any case - I think this plugin will be very helpful for my workflow - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants