Finish the review of TODOs for the Beta #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…have their own caches
…an using `codecName` and looking that up in `codecs`). All related APIs have thus simplified, e.g. the step `node(codecs, handler, $id)` is now `node(handler, $id)`, etc. TypeScript should point out any issues you have hopefully.
This reverts commit 8fa6f45.
… the plan diagram unless you pass `true` as the second option (`constant(foo, true)`) or `foo` is something very basic like `null`/`undefined`/`true`/`false`. This is to protect your secrets.
…er the existing GraphQL context, but instead the GraphQL request details (which contains the `contextValue`). If you were using this (unlikely), add `.contextValue` to usage of the second argument.
…d on `AccessPlan` can happen after the AccessPlan is optimized.
…`operationOperationPlansCacheMaxLength` configuration via `schema.extensions.grafast.*`. Currently undocumented.
…ultiple schemas will not cause degraded performance from clearing the cache.
…sions` and the same for most other `Grafast*Extensions` interfaces. This is to make TypeScript declaration merging easier.
…vents memory exhaustion in the case of poorly written consumer code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #381