Finish the review of TODOs for the Beta

.changeset/early-teachers-fry.md

@@ -0,0 +1,10 @@
+---
+"graphile-build-pg": patch
+"graphile-build": patch
+"postgraphile": patch
+---
+
+`codec` is now baked into NodeId handlers (rather than using `codecName` and
+looking that up in `codecs`). All related APIs have thus simplified, e.g. the
+step `node(codecs, handler, $id)` is now `node(handler, $id)`, etc. TypeScript
+should point out any issues you have hopefully.

.changeset/five-moles-study.md

@@ -0,0 +1,8 @@
+---
+"postgraphile": patch
+"grafast": patch
+---
+
+Grafast now supports `operationsCacheMaxLength` and
+`operationOperationPlansCacheMaxLength` configuration via
+`schema.extensions.grafast.*`. Currently undocumented.

.changeset/giant-spoons-give.md

@@ -0,0 +1,5 @@
+---
+"graphile-build-pg": patch
+---
+
+Export `parseDatabaseIdentifier`

.changeset/hot-snails-complain.md

@@ -0,0 +1,8 @@
+---
+"grafast": patch
+---
+
+`constant(foo)` no longer adds the value of `foo` to the plan diagram unless you
+pass `true` as the second option (`constant(foo, true)`) or `foo` is something
+very basic like `null`/`undefined`/`true`/`false`. This is to protect your
+secrets.

.changeset/khaki-lies-destroy.md

@@ -0,0 +1,8 @@
+---
+"@dataplan/pg": patch
+"graphile-build-pg": patch
+"postgraphile": patch
+"grafast": patch
+---
+
+`deepEval` has been renamed to `applyTransforms`

.changeset/light-ducks-burn.md

@@ -0,0 +1,7 @@
+---
+"grafast": patch
+---
+
+Move `GrafastFieldExtensions` to `Grafast.FieldExtensions` and the same for most
+other `Grafast*Extensions` interfaces. This is to make TypeScript declaration
+merging easier.

.changeset/loud-fishes-draw.md

@@ -0,0 +1,6 @@
+---
+"grafast": patch
+---
+
+Fix planning such that OutputPlan optimizations based on `AccessPlan` can happen
+after the AccessPlan is optimized.

.changeset/real-moons-relate.md

@@ -0,0 +1,7 @@
+---
+"postgraphile": patch
+"grafast": patch
+---
+
+Grafast operation cache now tied to the schema, so multiple schemas will not
+cause degraded performance from clearing the cache.

.changeset/real-shrimps-juggle.md

@@ -0,0 +1,9 @@
+---
+"postgraphile": patch
+"grafast": patch
+---
+
+`preset.grafast.context` second parameter is no longer the existing GraphQL
+context, but instead the GraphQL request details (which contains the
+`contextValue`). If you were using this (unlikely), add `.contextValue` to usage
+of the second argument.

.changeset/sharp-turkeys-remember.md

@@ -0,0 +1,5 @@
+---
+"postgraphile": patch
+---
+
+Rename 'postgraphilePresetAmber' to 'PostGraphileAmberPreset'

.changeset/small-panthers-work.md

@@ -0,0 +1,6 @@
+---
+"@grafserv/persisted": patch
+---
+
+Use an LRU for caching the getter from options - prevents memory exhaustion in
+the case of poorly written consumer code.

grafast/dataplan-pg/src/datasource.ts

@@ -690,7 +690,7 @@ export class PgResource<
         step:
           stepOrConstant instanceof ExecutableStep
             ? stepOrConstant
-            : constant(stepOrConstant),
+            : constant(stepOrConstant, false),
         codec,
         matches: (alias: SQL) =>
           typeof attribute.expression === "function"

grafast/dataplan-pg/src/examples/exampleSchema.ts

@@ -1638,7 +1638,9 @@ export function makeExampleSchema(
      * because it's not being ran as part of a Grafast planning context - hence
      * the `if`.
      */
-    const $person = registry.pgResources.people.get({ person_id: constant(1) });
+    const $person = registry.pgResources.people.get({
+      person_id: constant(1, false),
+    });
     const $posts = $person.manyRelation("posts");
     const $post = $posts.single();
     const $id = $post.get("post_id");
@@ -4139,7 +4141,7 @@ export function makeExampleSchema(
             function plan(_$root, { $id }) {
               const $item: SingleTableItemStep = singleTableItemsResource.get({
                 id: $id as ExecutableStep<number>,
-                type: constant("TOPIC"),
+                type: constant("TOPIC", false),
               });
               return $item;
             },
@@ -4451,7 +4453,7 @@ export function makeExampleSchema(
                 attribute: "cvss_score",
                 callback: (alias) =>
                   sql`${alias} > ${$vulnerabilities.placeholder(
-                    constant(6),
+                    constant(6, false),
                     TYPES.float,
                   )}`,
               });
@@ -4884,7 +4886,7 @@ export function makeExampleSchema(
             function plan(_$root, fieldArgs) {
               const $item = pgInsertSingle(relationalItemsResource, {
                 type: constant`POST`,
-                author_id: constant(2),
+                author_id: constant(2, false),
               });
               const $itemId = $item.get("id");
               const $post = pgInsertSingle(relationalPostsResource, {
@@ -4941,13 +4943,13 @@ export function makeExampleSchema(
               for (let i = 0; i < 3; i++) {
                 const $item = pgInsertSingle(relationalItemsResource, {
                   type: constant`POST`,
-                  author_id: constant(2),
+                  author_id: constant(2, false),
                 });
                 const $itemId = $item.get("id");
                 $post = pgInsertSingle(relationalPostsResource, {
                   id: $itemId,
-                  title: constant(`Post #${i + 1}`),
-                  description: constant(`Desc ${i + 1}`),
+                  title: constant(`Post #${i + 1}`, false),
+                  description: constant(`Desc ${i + 1}`, false),
                   note: constant(null),
                 });
               }
@@ -4983,11 +4985,11 @@ export function makeExampleSchema(
                     sql`interfaces_and_unions.insert_post(${authorId.placeholder}, ${title.placeholder})`,
                   args: [
                     {
-                      step: constant(2),
+                      step: constant(2, false),
                       pgCodec: TYPES.int,
                     },
                     {
-                      step: constant(`Computed post #${i + 1}`),
+                      step: constant(`Computed post #${i + 1}`, false),
                       pgCodec: TYPES.text,
                     },
                   ],

grafast/dataplan-pg/src/steps/pgSelect.ts

@@ -20,11 +20,11 @@ import {
   __ItemStep,
   __TrackedValueStep,
   access,
+  applyTransforms,
   arrayOfLength,
   ConnectionStep,
   constant,
   ConstantStep,
-  deepEval,
   ExecutableStep,
   exportAs,
   first,
@@ -786,7 +786,7 @@ export class PgSelectStep<
       );
     }
 
-    const $evalledStep = deepEval($step);
+    const $evalledStep = applyTransforms($step);
 
     const dependencyIndex = this.addDependency($evalledStep);
     const symbol = Symbol(`step-${$step.id}`);

grafast/dataplan-pg/src/steps/pgUnionAll.ts

@@ -1519,7 +1519,7 @@ and ${condition(i + 1)}`}
   optimize() {
     if (this.memberDigests.length === 0) {
       // We have no implementations, we'll never return anything
-      return constant([]);
+      return constant([], false);
     }
 
     this.planLimitAndOffset();

grafast/grafast/src/args.ts

@@ -29,19 +29,19 @@ export function hookArgs(
   const finalize = (args: ExecutionArgs) => {
     const userContext = resolvedPreset.grafast?.context;
     if (typeof userContext === "function") {
-      const result = userContext(ctx, args.contextValue as Record<string, any>);
+      const result = userContext(ctx, args);
       if (isPromiseLike(result)) {
         // Deliberately shadowed 'result'
         return result.then((result) => {
-          Object.assign(args.contextValue as Record<string, any>, result);
+          Object.assign(args.contextValue as Partial<Grafast.Context>, result);
           return args;
         });
       } else {
-        Object.assign(args.contextValue as Record<string, any>, result);
+        Object.assign(args.contextValue as Partial<Grafast.Context>, result);
         return args;
       }
     } else if (typeof userContext === "object" && userContext !== null) {
-      Object.assign(args.contextValue as Record<string, any>, userContext);
+      Object.assign(args.contextValue as Partial<Grafast.Context>, userContext);
       return args;
     } else {
       return args;

grafast/grafast/src/engine/OperationPlan.ts

@@ -34,7 +34,7 @@ import {
   object,
   SafeError,
 } from "../index.js";
-import { inputPlan } from "../input.js";
+import { inputStep } from "../input.js";
 import { inspect } from "../inspect.js";
 import type {
   FieldPlanResolver,
@@ -387,17 +387,9 @@ export class OperationPlan {
     this.checkTimeout();
     this.lap("optimizeSteps");
 
-    // Replace access plans with direct access, etc
-    te.batch(() => {
-      this.optimizeOutputPlans();
-    });
-
-    this.checkTimeout();
-    this.lap("optimizeOutputPlans");
-
     this.phase = "finalize";
 
-    this.stepTracker.finalize();
+    this.stepTracker.finalizeSteps();
 
     // Get rid of steps that are no longer needed after optimising outputPlans
     // (we shouldn't see any new steps or dependencies after here)
@@ -420,6 +412,22 @@ export class OperationPlan {
 
     this.lap("finalizeSteps");
 
+    // Replace access plans with direct access, etc (must come after finalizeSteps)
+    te.batch(() => {
+      this.optimizeOutputPlans();
+    });
+
+    this.checkTimeout();
+    this.lap("optimizeOutputPlans");
+
+    // AccessSteps may have been removed
+    this.stepTracker.treeShakeSteps();
+
+    this.checkTimeout();
+    this.lap("treeShakeSteps", "optimizeOutputPlans");
+
+    this.stepTracker.finalizeOutputPlans();
+
     te.batch(() => {
       this.finalizeLayerPlans();
     });
@@ -1169,6 +1177,7 @@ export class OperationPlan {
         // ENHANCEMENT: should we do `step = parentStep.object()` (i.e.
         // `$pgSelectSingle.record()`) or similar for "opaque" steps to become
         // suitable for consumption by resolvers?
+        // Maybe `parentStep.forResolver()` or `parentStep.hydrate()` or `parentStep.toFullObject()`?
         step = parentStep;
       }
 
@@ -1701,9 +1710,8 @@ export class OperationPlan {
       }
       for (const t of allPossibleObjectTypes) {
         if (!layerPlan.reason.typeNames.includes(t.name)) {
-          // TODO: do I need to do anything extra here? Since we're re-using an
-          // existing LayerPlan, we should be careful to ensure none of the
-          // previous assumptions have been broken.
+          // Since we're re-using an existing LayerPlan, we should be careful to
+          // ensure none of the previous assumptions have been broken.
           layerPlan.reason.typeNames.push(t.name);
         }
       }
@@ -1885,7 +1893,7 @@ export class OperationPlan {
       const argumentValue = argumentValues?.find(
         (v) => v.name.value === argumentName,
       );
-      const argumentPlan = inputPlan(
+      const argumentPlan = inputStep(
         this,
         argumentType,
         argumentValue?.value,

grafast/grafast/src/engine/OutputPlan.ts

@@ -1230,7 +1230,7 @@ const arrayExecutorString_nonNullable_streaming = makeArrayExecutor(
  * workaround until we can afford the time to write our own introspection
  * execution.
  *
- * TODO: write our own introspection execution!
+ * ENHANCE: write our own introspection execution!
  */
 const introspect = (
   root: PayloadRoot,

grafast/grafast/src/engine/StepTracker.ts

@@ -73,19 +73,34 @@ export class StepTracker {
     return (this.stepById as ExecutableStep[]).slice(oldStepCount);
   }
 
-  /** Called when OperationPlan enters finalize phase. */
-  public finalize() {
-    const forbidden = () => {
-      throw new Error(`Forbidden after 'finalize' phase`);
+  private forbid(
+    key: keyof {
+      [K in keyof StepTracker as StepTracker[K] extends (...args: any[]) => any
+        ? K
+        : never]: any;
+    },
+  ) {
+    this[key] = () => {
+      throw new Error(
+        `StepTracker.${key as string}(...) is forbidden after 'finalize' phase`,
+      );
     };
-    this.addStep = forbidden;
-    this.addLayerPlan = forbidden;
-    this.addOutputPlan = forbidden;
-    this.deleteLayerPlan = forbidden;
-    this.addStepDependency = forbidden;
-    this.setOutputPlanRootStep = forbidden;
-    this.setLayerPlanRootStep = forbidden;
-    this.replaceStep = forbidden;
+  }
+
+  /** Called when OperationPlan enters finalize phase. */
+  public finalizeSteps() {
+    this.forbid("addStep");
+    this.forbid("addLayerPlan");
+    this.forbid("addOutputPlan");
+    this.forbid("deleteLayerPlan");
+    this.forbid("addStepDependency");
+    this.forbid("setLayerPlanRootStep");
+    this.forbid("replaceStep");
+  }
+
+  /** Called when OperationPlan is about to finalize the output plans. */
+  public finalizeOutputPlans() {
+    this.forbid("setOutputPlanRootStep");
   }
 
   public addStep($step: ExecutableStep): number {