Fix misrepresentation of alerts. #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PSA: @funkypenguin @intrand if you are still using this, you will want to update your versions since it could mis-report the status of some alerts |
|
Thanks @benjojo ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when only a subset of alerts in a group resolves, the program will post the message as if all alerts in the group are firing. This is incorrect.
This PR changes the behavior such that resolved alerts are displayed as resolved.
The source of the problem is that the program is currently only looking at the "common" status of the alerts, not at the individual alerts' status. This PR changes that by first sorting the alerts into lists based on their status, and then sending individual messages for each of the lists.