You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When installing, the user is prompted for a git user name and email, overwriting any that are currently present. This allows users to maintain their git identity and still pull in my git config.
This should be seamless and easy to maintain as changed, despite the fact that my repo's copy has my name and email.
Current Behavior
The issue is that as soon as the git config file has changed, the local repo has diverged from the remote. This would likely cause issues with pulls either
overwriting the changed info, possibly causing the user to unknowingly change identities or
causing conflicts, which is not a seamless user interaction
Possible Solution
Instead of overwriting the values in the file, consider two approaches.
Symlink iff Ben Knoble
Prompt if Ben Knoble
If yes
Symlink git config
If no
cp git config
Prompt for new values
or
Copy the file in place
cp git config
Prompt for user name and email
The first has the advantage that it's easier for me, as my copy is in sync with the repo always, &c. The second has the advantage that the script is simpler; it does the same thing no matter what.
The disadvantage for both is that any users other than me will need to occasionally see if the gitconfig file has been updated (mercifully this is now rare) and then cp it over, changing the values as necessary. That is, they should occasionally rerun setup/git-setup.sh with whatever fix is introduced.
Steps to Reproduce (for bugs)
bootstrap this project and provide a different user and email when prompted.
Pull in new changes.
Your Environment
Version used: Dotfiles 1.0 Bootstrap
Operating System and version: OS X 10.11.6
CLI used: Terminal
Version info of relevant software: git 2.13.3
The text was updated successfully, but these errors were encountered:
Expected Behavior
When installing, the user is prompted for a git user name and email, overwriting any that are currently present. This allows users to maintain their git identity and still pull in my git config.
This should be seamless and easy to maintain as changed, despite the fact that my repo's copy has my name and email.
Current Behavior
The issue is that as soon as the git config file has changed, the local repo has diverged from the remote. This would likely cause issues with pulls either
Possible Solution
Instead of overwriting the values in the file, consider two approaches.
Symlink iff Ben Knoble
cp
git configor
Copy the file in place
cp
git configThe first has the advantage that it's easier for me, as my copy is in sync with the repo always, &c. The second has the advantage that the script is simpler; it does the same thing no matter what.
The disadvantage for both is that any users other than me will need to occasionally see if the gitconfig file has been updated (mercifully this is now rare) and then
cp
it over, changing the values as necessary. That is, they should occasionally rerunsetup/git-setup.sh
with whatever fix is introduced.Steps to Reproduce (for bugs)
bootstrap
this project and provide a different user and email when prompted.Your Environment
git 2.13.3
The text was updated successfully, but these errors were encountered: