Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.3 #101

Merged
merged 15 commits into from
Sep 9, 2017
Merged

Version 1.3 #101

merged 15 commits into from
Sep 9, 2017

Conversation

benknoble
Copy link
Owner

Description

Major changes are using brew bundle, plus a few bug fixes.

Oh, and don't forget the massive shell script re-indentation. There was that too.

Related Issue

#32
#85
#44

Motivation and Context

It solves the brew dependency installation problem

How Has This Been Tested?

Brew bundle tested; some of the scripts somewhat tested.

Behavior

When you install, it is easier to install all the brew formulae. Updating also notifies you if brew is out of date.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have tested my feature as described in CONTRIBUTING.

Also source scala completion

This eliminates a weird path dependency local to my machine.

Closes #85
Note that cask completion only really works if you type "brew-cask"...
I know this is a weird thing to do in a branch that is supposed to be
work on v1.3, but this had to be done at some point and I'd rather avoid
merge conflicts if possible.
The --force is necessary to overwrite the Brewfile

Part of #32
The "which" guard ensures that systems without brew don't try to run
brew, like a Linux server

Part of #32
Next series of steps involve changing the install scripts (for #32)
Next steps for #32 are docs updates
@benknoble benknoble added this to the Version 1.3 milestone Sep 9, 2017
@benknoble benknoble self-assigned this Sep 9, 2017
@benknoble benknoble changed the base branch from master to dev-1.3 September 9, 2017 20:33
@benknoble benknoble merged commit f750190 into dev-1.3 Sep 9, 2017
@benknoble benknoble mentioned this pull request Sep 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant