Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inclusion in Vim runtime #7

Open
1 of 3 tasks
benknoble opened this issue Jan 24, 2022 · 7 comments
Open
1 of 3 tasks

Inclusion in Vim runtime #7

benknoble opened this issue Jan 24, 2022 · 7 comments

Comments

@benknoble
Copy link
Owner

benknoble commented Jan 24, 2022

Based on a suggestion from @dkearns, it might be worth including this in the vim distribution.

What remains to be done for that to be possible?

  • As I understand it, I need to license the project under a Vim-compatible license.
  • It seems like there's a special file-header that is often used (what exactly is it?).
  • Anything else?
@dkearns
Copy link

dkearns commented Jan 24, 2022

The file detection needs to be added as well. The autocmd would go in runtime/filetype.vim, the function in runtime/autoload/dist/ft.vim and tests in src/testdir/test_filetype.vim

I'll submit a PR here with the header additions later today.

@benknoble
Copy link
Owner Author

Ok, good to know. I should mention that the filetype detection will change somewhat radically; I've opted for an approach that says "Racket is an ecosystem of languages; rather than naïvely try to apply racket filetype settings to all the languages in the ecosystem, build an ecosystem for many filetype settings." That is, somethings are #lang racket-like, but others are very much not (#lang datalog, for example, really needs its own syntax), so they should have filetypes that are not racket.

Some people have complained and/or don't like it, but there are workarounds and fixes. For example, updating the mapping in this plugin, or extending/overriding it (I need to write docs…).

@benknoble
Copy link
Owner Author

"Change somewhat radically"—I mean from what currently exists in vim, not from how this plugin currently operates.

@dkearns
Copy link

dkearns commented Jan 24, 2022

Would it be worthwhile just including the racket filetype to start?

@benknoble
Copy link
Owner Author

Possibly—that would include the ftplugin, syntax, and indent for racket, but not the filetype detection bit or the related plugins for other #langs that have accumulated here.

@benknoble
Copy link
Owner Author

Linking PR #8

@dkearns
Copy link

dkearns commented Aug 29, 2022

#10 handles Bram's recent comments on your submission.

Sorry, I always forget to add that boiler plate. Vim9 script does away with the need for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants