Separate metrics into own pages #47
Comments
benlei
added
documentation
benlei
added
investigate
benlei
changed the title
benlei
changed the title
|
Done |
benlei
added a commit
that referenced
this issue
Apr 16, 2023
* setting up a new logo, choosing a trim * use css more * use css more again, use bigger logo * no more pointing menu * starting to setup last run summary page options * using search * removing search/dropdown/etc... it looks kinda bad and doesnt work so well * removing options to keep page as simple as possible * avg summary i think is good enough now * remove plural * setting up runs page * setting up longest leaderboard * finished setting up shortest leaderboard * post fixes, can build now at least * rename run summary to simply runs. adding more smoke tests for each page * removing unnecessary files * more minor adjustments
benlei
added a commit
that referenced
this issue
Apr 17, 2023
* #45 - delete unused pages (#50) * closes #22 dark mode (#53) * #22 - compiled semantic ui css stuff * #22 - overall in progress, but it's looking very solid * #22 - added light mode/dark mode switcher * #22 - updating footer. * #22 - updating inverted bg color to use custom props too * #22 - make sort button bigger * #22 - update button hover/active color * #22 - adjusting table border props - it wasnt displaying right for dark mode * #22 - trying to get the history table to not burn the eyes/cause discomfort still in progress * make bg darker * generated: automatic data updating * #22 - alright this looks pretty good for history table * #22 - alright this looks pretty good for history table * #22 - just use default html2canvas options... * closes #52 - track image downloads * old note --------- Co-authored-by: github-actions <github-actions@github.com> * locking some dep versions * #22 - making runs not use a box * going all pnpm now * run on v2-trunk * not sure how it got lost but here it is * maybe wrong command? * hmm maybe install with deps still? * try this instead? * perhaps needs playwright explicitly too * perhaps needs playwright explicitly too * update config to skip test stuff * remvoe safari * maybe just need eslint * alright so i guess we gotta make * alright this should make things more flexible * Use samsara tools v1 (#56) * adding in banners.yaml, will have to slowly swap banners.json out * updating to start using the yaml * removing unused file * updating history to use yaml * minor runs css change * 42 summary layout change (#58) * updating images, experimenting with diff layout * fixed a banner bug, i think this is what i'll go with for relativity stuff * adding notes for me for later * styling changes, thinking about it more dropping the last stuff * getting it to a base case * alright leaderboard set up * alright longest leaderboard set up, will need to work on shortest now * replacing shortest leaderboard stuff too now * use colspan for image+featured name * updating relative counter style again, i think this looks overall better * leaderboard header follow same as summary * alright avg counters stay separate * basic counter looking good here * ide auto format * fixing build issue * adding pr builds for v2-trunk * post update to #42 - add bg color for headers * #46 use borger menu (#59) * we got the borger menu now! * remove border top for sidebar * remove border bottom from menu * #47 separate page metrics (#60) * setting up a new logo, choosing a trim * use css more * use css more again, use bigger logo * no more pointing menu * starting to setup last run summary page options * using search * removing search/dropdown/etc... it looks kinda bad and doesnt work so well * removing options to keep page as simple as possible * avg summary i think is good enough now * remove plural * setting up runs page * setting up longest leaderboard * finished setting up shortest leaderboard * post fixes, can build now at least * rename run summary to simply runs. adding more smoke tests for each page * removing unnecessary files * more minor adjustments * adjustments for mobile usage * more adjustments for mobile * adjustments for mobile for history stuff * updating history test * hide the sort in mobile * fix avg summary page not sorting from buttons * add border left to featured char/weap name * adjusting options more * updating search capabilities, adding a blurb about it * making the way the header is shown consistent with summary * adding a popover for the character header * adding popover for history table * reduce size of featured name * separate out the part from version shown --------- Co-authored-by: github-actions <github-actions@github.com>
benlei
added a commit
that referenced
this issue
Apr 17, 2023
* #45 - delete unused pages (#50) * closes #22 dark mode (#53) * #22 - compiled semantic ui css stuff * #22 - overall in progress, but it's looking very solid * #22 - added light mode/dark mode switcher * #22 - updating footer. * #22 - updating inverted bg color to use custom props too * #22 - make sort button bigger * #22 - update button hover/active color * #22 - adjusting table border props - it wasnt displaying right for dark mode * #22 - trying to get the history table to not burn the eyes/cause discomfort still in progress * make bg darker * generated: automatic data updating * #22 - alright this looks pretty good for history table * #22 - alright this looks pretty good for history table * #22 - just use default html2canvas options... * closes #52 - track image downloads * old note --------- Co-authored-by: github-actions <github-actions@github.com> * locking some dep versions * #22 - making runs not use a box * going all pnpm now * run on v2-trunk * not sure how it got lost but here it is * maybe wrong command? * hmm maybe install with deps still? * try this instead? * perhaps needs playwright explicitly too * perhaps needs playwright explicitly too * update config to skip test stuff * remvoe safari * maybe just need eslint * alright so i guess we gotta make * alright this should make things more flexible * Use samsara tools v1 (#56) * adding in banners.yaml, will have to slowly swap banners.json out * updating to start using the yaml * removing unused file * updating history to use yaml * minor runs css change * 42 summary layout change (#58) * updating images, experimenting with diff layout * fixed a banner bug, i think this is what i'll go with for relativity stuff * adding notes for me for later * styling changes, thinking about it more dropping the last stuff * getting it to a base case * alright leaderboard set up * alright longest leaderboard set up, will need to work on shortest now * replacing shortest leaderboard stuff too now * use colspan for image+featured name * updating relative counter style again, i think this looks overall better * leaderboard header follow same as summary * alright avg counters stay separate * basic counter looking good here * ide auto format * fixing build issue * adding pr builds for v2-trunk * post update to #42 - add bg color for headers * #46 use borger menu (#59) * we got the borger menu now! * remove border top for sidebar * remove border bottom from menu * #47 separate page metrics (#60) * setting up a new logo, choosing a trim * use css more * use css more again, use bigger logo * no more pointing menu * starting to setup last run summary page options * using search * removing search/dropdown/etc... it looks kinda bad and doesnt work so well * removing options to keep page as simple as possible * avg summary i think is good enough now * remove plural * setting up runs page * setting up longest leaderboard * finished setting up shortest leaderboard * post fixes, can build now at least * rename run summary to simply runs. adding more smoke tests for each page * removing unnecessary files * more minor adjustments * #51 redesign history options with patch info (#62) * #45 - delete unused pages (#50) * closes #22 dark mode (#53) * #22 - compiled semantic ui css stuff * #22 - overall in progress, but it's looking very solid * #22 - added light mode/dark mode switcher * #22 - updating footer. * #22 - updating inverted bg color to use custom props too * #22 - make sort button bigger * #22 - update button hover/active color * #22 - adjusting table border props - it wasnt displaying right for dark mode * #22 - trying to get the history table to not burn the eyes/cause discomfort still in progress * make bg darker * generated: automatic data updating * #22 - alright this looks pretty good for history table * #22 - alright this looks pretty good for history table * #22 - just use default html2canvas options... * closes #52 - track image downloads * old note --------- Co-authored-by: github-actions <github-actions@github.com> * locking some dep versions * #22 - making runs not use a box * going all pnpm now * run on v2-trunk * not sure how it got lost but here it is * maybe wrong command? * hmm maybe install with deps still? * try this instead? * perhaps needs playwright explicitly too * perhaps needs playwright explicitly too * update config to skip test stuff * remvoe safari * maybe just need eslint * alright so i guess we gotta make * alright this should make things more flexible * Use samsara tools v1 (#56) * adding in banners.yaml, will have to slowly swap banners.json out * updating to start using the yaml * removing unused file * updating history to use yaml * minor runs css change * 42 summary layout change (#58) * updating images, experimenting with diff layout * fixed a banner bug, i think this is what i'll go with for relativity stuff * adding notes for me for later * styling changes, thinking about it more dropping the last stuff * getting it to a base case * alright leaderboard set up * alright longest leaderboard set up, will need to work on shortest now * replacing shortest leaderboard stuff too now * use colspan for image+featured name * updating relative counter style again, i think this looks overall better * leaderboard header follow same as summary * alright avg counters stay separate * basic counter looking good here * ide auto format * fixing build issue * adding pr builds for v2-trunk * post update to #42 - add bg color for headers * #46 use borger menu (#59) * we got the borger menu now! * remove border top for sidebar * remove border bottom from menu * #47 separate page metrics (#60) * setting up a new logo, choosing a trim * use css more * use css more again, use bigger logo * no more pointing menu * starting to setup last run summary page options * using search * removing search/dropdown/etc... it looks kinda bad and doesnt work so well * removing options to keep page as simple as possible * avg summary i think is good enough now * remove plural * setting up runs page * setting up longest leaderboard * finished setting up shortest leaderboard * post fixes, can build now at least * rename run summary to simply runs. adding more smoke tests for each page * removing unnecessary files * more minor adjustments * adjustments for mobile usage * more adjustments for mobile * adjustments for mobile for history stuff * updating history test * hide the sort in mobile * fix avg summary page not sorting from buttons * add border left to featured char/weap name * adjusting options more * updating search capabilities, adding a blurb about it * making the way the header is shown consistent with summary * adding a popover for the character header * adding popover for history table * reduce size of featured name * separate out the part from version shown --------- Co-authored-by: github-actions <github-actions@github.com> * closes #54 * updating meta information * #51 show irrelevant featured (#63) * adding n/a avg entries + making it less opaque * adding n/a leaderboard type entries * #39 save sort settings (#64) * setting storage for history page... * adding storage for everything else * updating banners yaml --------- Co-authored-by: github-actions <github-actions@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm thinking that instead of having a sort by metrics page, perhaps I can split each metric up to its own page. In other words have a dedicated page for since last run, a dedicated page for longest wait leaderboard, so on and so forth.
In my mind at least, this will make pages look a lot more simple, and can make it so that certain pages can be bookmarked/shareable.
Do this after #42, though.
Note: If I wanna keep the metrics selection still, a hybrid solution would be to keep it + separate the metric pages, but utilize the route history API to every time the metric is changed.
The text was updated successfully, but these errors were encountered: