Potential fix for the IE 11 #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IE 11 has Event defined, but throws if constructor is invoked Closes #1
|
Works for me in IE11. Should be safe, The other issue is that it isn't transpiled to ES5 so breaks in IE11. IMHO it makes sense for polyfills to target ES5 & it's relatively trivial with a Babel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1
It seems, that minimal required change would be checking if
typeof Eventis"object".It should be
"function"in all browsers that supportnew Event()(I am referring to this quite old stackoverflow question), although I'm not quite sure how safe this actually is.