add jwt_add_grant_bool and jwt_get_grant_bool #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #49 +/- ##
==========================================
+ Coverage 94.48% 94.65% +0.16%
==========================================
Files 3 3
Lines 653 673 +20
==========================================
+ Hits 617 637 +20
Misses 36 36
Continue to review full report at Codecov.
|
|
Please review decreased code coverage and try to address test cases to maintain the current level. |
benmcollins
requested changes
Aug 14, 2017
libjwt/jwt.c
Outdated
|
|
||
| js_val = json_object_get(js, key); | ||
| if (js_val) | ||
| val = (int)json_boolean_value(js_val); |
There was a problem hiding this comment.
You're going to need to add something to define json_boolean_value for older JANSSON.
include/jwt.h
Outdated
| @@ -160,7 +160,8 @@ const char *jwt_get_grant(jwt_t *jwt, const char *grant); | |||
| * @param jwt Pointer to a JWT object. | |||
| * @param grant String containing the name of the grant to return a value | |||
| * for. | |||
| * @return Returns an int for the value, or 0 when not found. | |||
| * @return Returns an int for the value, with errno set ENOENT when | |||
There was a problem hiding this comment.
Returns an int for the value. Sets errno to ENOENT when not found.
include/jwt.h
Outdated
| * for. | ||
| * @return Returns booean for the value, with errno set ENOENT when | ||
| * not found. | ||
| * |
There was a problem hiding this comment.
Same as above comment (fix wording/grammar).
benmcollins
approved these changes
Aug 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.