Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sundown to recent version #16

Closed
przemoc opened this issue Jun 19, 2012 · 7 comments
Closed

Update sundown to recent version #16

przemoc opened this issue Jun 19, 2012 · 7 comments

Comments

@przemoc
Copy link

przemoc commented Jun 19, 2012

Over the year sundown had many improvements and bug fixes. Thus it would be good to update sundown submodule in robotskirt repo.

@mildsunrise
Copy link
Collaborator

Yeah, we're looking into it. See this thread.
Anyway, keep in mind that there are new features,
and it's not just update.

@przemoc
Copy link
Author

przemoc commented Jun 19, 2012

Sure, thanks for the link. I haven't noticed that there was previous update-related discussion.

I think that sundown upgrade procedure alone deserves it's own ticket, but if you think otherwise feel free to close it.

@mildsunrise
Copy link
Collaborator

No, you're right, it deserves. :)

@przemoc
Copy link
Author

przemoc commented Jun 19, 2012

BTW I've created the issue 46 at blacksmith (a static site generator built with Node.js, JSDOM, and Weld) about switching it from marked to Robotskirt.

@mildsunrise
Copy link
Collaborator

@benmills @przemoc
I've already created an unstable branch,
and updated the submodule to the last commit.

Previous commit: 5d201dbcdc291adfa9c2dc4f8ddb2ff1fe6202a9
Current commit: c744346e507e7f905d4b401de78db4404068a43c
You can see the diff and commits here.

@mildsunrise
Copy link
Collaborator

Now Sundown is at his very latest version,
and Robotskirt is at all his glory wih the flaming v2.
Now, you can do:

var rs = require('robotskirt');
console.log(rs.versions.sundown);

To see the version of the bundled Sundown.

@mildsunrise
Copy link
Collaborator

I'm closing the issue, feel free to reopen it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants