Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] `default`: make message less confusing #1470

Merged
merged 1 commit into from Sep 4, 2019

Conversation

@golopot
Copy link
Contributor

commented Sep 4, 2019

Fixes #751, fixes #786.

@ljharb ljharb force-pushed the golopot:default-message branch from 0b1ced8 to 43172af Sep 4, 2019

@ljharb
ljharb approved these changes Sep 4, 2019
@coveralls

This comment has been minimized.

Copy link

commented Sep 4, 2019

Coverage Status

Coverage decreased (-0.002%) to 97.9% when pulling 0b1ced8 on golopot:default-message into 7ffbf03 on benmosher:master.

@coveralls

This comment has been minimized.

Copy link

commented Sep 4, 2019

Coverage Status

Coverage decreased (-0.002%) to 97.9% when pulling 726dda5 on golopot:default-message into 7ffbf03 on benmosher:master.

@ljharb ljharb force-pushed the golopot:default-message branch from 43172af to 726dda5 Sep 4, 2019

@ljharb ljharb merged commit 726dda5 into benmosher:master Sep 4, 2019

2 of 6 checks passed

coverage/coveralls Coverage decreased (-0.002%) to 97.9%
Details
Tidelift Scanning dependencies
Details
continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@golopot golopot deleted the golopot:default-message branch Sep 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.