Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Message for default rule could be clearer #786

Closed
jamestalmage opened this issue Apr 3, 2017 · 1 comment · Fixed by #1470
Closed

Message for default rule could be clearer #786

jamestalmage opened this issue Apr 3, 2017 · 1 comment · Fixed by #1470
Labels
enhancement help wanted

Comments

@jamestalmage
Copy link

jamestalmage commented Apr 3, 2017 •
edited

No default export found in module.

Should be

No default export found in referenced module "./foo".

The current wording does not make clear that the error is taking about the reference module, which left me troubleshooting the file with the import statement (which in this case also didn't have a default export - but I got really confused when I fixed that)
@ljharb
Copy link
Member

ljharb commented Apr 3, 2017

Sounds reasonable to me. Better error messages are always helpful.

@golopot golopot mentioned this issue Sep 4, 2019
Merged
ljharb pushed a commit to golopot/eslint-plugin-import that referenced this issue Sep 4, 2019
@golopot @ljharb
[fix] default: make error message less confusing
43172af 
Fixes import-js#751, fixes import-js#786
@ljharb ljharb closed this as completed in 726dda5 Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[feat] default: make message less confusing golopot/eslint-plugin-import
2 participants
@ljharb @jamestalmage