Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Update test infrastructure and babel #1686
I wanted to work on #1481 but the tests were failing locally. This PR fixes that.
Main change : babel configuration
The tests failed on master because the
The problem was from some dynamic require. I fixed the problem here: adjerbetian@3e592e6.
Other change: mocha configuration
Note: as I updated mocha so it supports
ljharb left a comment
Babel 7 and Mocha 4+ don’t support the versions of node we need to test on, so we effectively can’t ever upgrade to them.
It’d be great to fix the local test failures without updating any majors.