New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prefer default in multiple named export case #343

Merged
merged 2 commits into from May 19, 2016

Conversation

Projects
None yet
2 participants
@scottnonnenberg
Copy link
Contributor

scottnonnenberg commented May 15, 2016

Fixes #342. Instead of counting the number of ExportNamedDeclaration nodes, we count the number of properties in its child ObjectPattern.

A couple other style fixes.

@benmosher

This comment has been minimized.

Copy link
Owner

benmosher commented May 17, 2016

It's close. Will provide feedback ASAP, next few days or so. 😄

@benmosher benmosher merged commit b377fc6 into benmosher:master May 19, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

benmosher added a commit that referenced this pull request May 19, 2016

Merge pull request #351 from benmosher/fix-prefer-default
Fix prefer default (#342, #343, #350, #351) #MostPRsEver
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment