Add allow option to no-nodejs-modules rule (fixes #452)
#509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, LGTM! |
1 similar comment
| @@ -2,7 +2,7 @@ import importType from '../core/importType' | |||
| import isStaticRequire from '../core/staticRequire' | |||
|
|
|||
| function reportIfMissing(context, node, allowed, name) { | |||
| if (!allowed.includes(name) && importType(name, context) === 'builtin') { | |||
| if (allowed.indexOf(name) === -1 && importType(name, context) === 'builtin') { | |||
There was a problem hiding this comment.
ah, bummer, I also thought Node v4 had includes.
There was a problem hiding this comment.
Not that surprising actually, since it's not even ES2015, but an ES2016 feature. I thought Babel would actually take care of this, but I guess was too hopeful (or it's just something to add). Anyway indexOf is fine.
|
I was thinking presets (like @graingert suggested) would be a good idea, but that can be a responsibility of shared configs. LGTM. 😎 |
|
|
This was referenced Apr 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
allowoption tono-nodejs-modulesrule (fixes #452)cc @ljharb