Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flip unread property in dataset #35

Merged
merged 6 commits into from Mar 4, 2018
Merged

Flip unread property in dataset #35

merged 6 commits into from Mar 4, 2018

Conversation

benmvp
Copy link
Owner

@benmvp benmvp commented Mar 4, 2018

The dataset, REST API & App functions all dealt with an unread property, which is a negative word. So things get real confusing when we had {unread: false}, which really could be better expressed as {read: true}.

So this flips the dataset, REST API & App functions to deal with read property instead of unread property. Nearly almost every source file had to change.

Fixes #20

@benmvp benmvp added react Dealing specifically with React components chore labels Mar 4, 2018
@benmvp benmvp added this to the Reactathon workshop milestone Mar 4, 2018
@benmvp benmvp self-assigned this Mar 4, 2018
@benmvp benmvp merged commit 8d139fb into master Mar 4, 2018
@benmvp benmvp deleted the flip-unread-dataset branch March 4, 2018 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore react Dealing specifically with React components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant