Skip to content

Commit

Permalink
Correct fix for EddyVerbruggen#1033
Browse files Browse the repository at this point in the history
This stops the direct activity sharing been selected on the android platform where instagram registers multiple activities as shown below:

- com.instagram.direct.share.handler.DirectExternalPhotoShareActivity
- com.instagram.share.handleractivity.ShareHandlerActivity
- com.instagram.share.handleractivity.StoryShareHandlerActivity
- com.instagram.share.handleractivity.MultiStoryShareHandlerActivity
The story share handler is implied by passing multiple images through to the plugin.
  • Loading branch information
bennimmo committed Jan 18, 2021
1 parent 527ceff commit 8bf99cd
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions src/android/nl/xservices/plugins/SocialSharing.java
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ public boolean execute(String action, JSONArray args, CallbackContext callbackCo
if (notEmpty(args.getString(0))) {
copyHintToClipboard(args.getString(0), "Instagram paste message");
}
return doSendIntent(callbackContext, args.getString(0), args.getString(1), args.getJSONArray(2), args.getString(3), "instagram", null, false, true);
return doSendIntent(callbackContext, args.getString(0), args.getString(1), args.getJSONArray(2), args.getString(3), "com.instagram.android", null, false, true, "com.instagram.share.handleractivity.ShareHandlerActivity");
} else if (ACTION_CAN_SHARE_VIA.equals(action)) {
return doSendIntent(callbackContext, args.getString(0), args.getString(1), args.getJSONArray(2), args.getString(3), args.getString(4), null, true, true);
} else if (ACTION_CAN_SHARE_VIA_EMAIL.equals(action)) {
Expand Down Expand Up @@ -680,10 +680,7 @@ private ActivityInfo getActivity(final CallbackContext callbackContext, final In
for (final ResolveInfo app : activityList) {
if ((app.activityInfo.packageName).contains(appPackageName)) {
if (appName == null || (app.activityInfo.name).contains(appName)) {
if (appPackageName == "instagram"
&& app.activityInfo.name.contains("ShareHandlerActivity")) {
return app.activityInfo;
}
return app.activityInfo;
}
}
}
Expand Down

0 comments on commit 8bf99cd

Please sign in to comment.