refactor: Prefer interfaces

bennycode · Dec 4, 2020 · 04d14c5 · 04d14c5
1 parent 5aa9993
commit 04d14c5
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 23 deletions.
diff --git a/src/client/WebSocketClient.ts b/src/client/WebSocketClient.ts
@@ -120,7 +120,7 @@ export enum WebSocketResponseType {
   TICKER = 'ticker',
 }
 
-export type WebSocketResponse = {type: WebSocketResponseType} & WebSocketMessage;
+export type WebSocketResponse = WebSocketMessage & {type: WebSocketResponseType};
 
 // Not exported because it will become "WebSocketResponse" once complete
 type WebSocketMessage =
@@ -130,13 +130,13 @@ type WebSocketMessage =
   | WebSocketMatchMessage
   | WebSocketErrorMessage;
 
-export type WebSocketErrorMessage = {
+export interface WebSocketErrorMessage {
   message: string;
   reason: string;
   type: WebSocketResponseType.ERROR;
-};
+}
 
-export type WebSocketMatchMessage = {
+export interface WebSocketMatchMessage {
   maker_order_id: UUID_V4;
   price: string;
   product_id: string;
@@ -147,9 +147,9 @@ export type WebSocketMatchMessage = {
   time: ISO_8601_MS_UTC;
   trade_id: number;
   type: WebSocketResponseType.FULL_MATCH;
-};
+}
 
-export type WebSocketStatusMessage = {
+export interface WebSocketStatusMessage {
   currencies: {
     convertible_to: string[];
     details: CurrencyDetail;
@@ -163,9 +163,9 @@ export type WebSocketStatusMessage = {
   }[];
   products: (Product & {type: 'spot'})[];
   type: WebSocketResponseType.STATUS;
-};
+}
 
-export type WebSocketTickerMessage = {
+export interface WebSocketTickerMessage {
   best_ask: string;
   best_bid: string;
   high_24h: string;
@@ -181,14 +181,14 @@ export type WebSocketTickerMessage = {
   type: WebSocketResponseType.TICKER;
   volume_24h: string;
   volume_30d: string;
-};
+}
 
 export type WebSocketLastMatchMessage = Omit<WebSocketMatchMessage, 'type'> & {type: WebSocketResponseType.LAST_MATCH};
 
-export type WebSocketSubscription = {
+export interface WebSocketSubscription {
   channels: WebSocketChannel[];
   type: WebSocketResponseType.SUBSCRIPTIONS;
-};
+}
 
 export enum WebSocketEvent {
   ON_CLOSE = 'WebSocketEvent.ON_CLOSE',

diff --git a/src/order/OrderAPI.ts b/src/order/OrderAPI.ts
@@ -55,23 +55,23 @@ type BasePlacedOrder = {
 
 export type NewOrder = LimitOrder | AutoCancelLimitOrder | PostOnlyLimitOrder | MarketOrder;
 
-export type AutoCancelLimitOrder = LimitOrder & {
+export interface AutoCancelLimitOrder extends LimitOrder {
   cancel_after: CancelOrderPeriod;
   time_in_force: TimeInForce.GOOD_TILL_TIME;
-};
+}
 
-export type PostOnlyLimitOrder = LimitOrder & {
+export interface PostOnlyLimitOrder extends LimitOrder {
   post_only: boolean;
   time_in_force: TimeInForce.GOOD_TILL_CANCELED | TimeInForce.GOOD_TILL_TIME;
-};
+}
 
-export type LimitOrder = BaseOrder & {
+export interface LimitOrder extends BaseOrder {
   price: string;
   size: string;
   /** Default is 'GTC'. */
   time_in_force?: TimeInForce;
   type: OrderType.LIMIT;
-};
+}
 
 export type MarketOrder = BaseOrder & {type: OrderType.MARKET} & ({size: string} | {funds: string});
 
@@ -82,17 +82,17 @@ export enum OrderStatus {
   PENDING = 'pending',
 }
 
-export type PendingOrder = BasePlacedOrder & {
+export interface PendingOrder extends BasePlacedOrder {
   status: OrderStatus.PENDING;
   stp: SelfTradePrevention;
-};
+}
 
-export type FilledOrder = BasePlacedOrder & {
+export interface FilledOrder extends BasePlacedOrder {
   done_at: ISO_8601_MS_UTC;
   done_reason: 'filled';
   profile_id: string;
   status: OrderStatus.DONE;
-};
+}
 
 export type Order = PendingOrder | FilledOrder;
 

diff --git a/src/payload/common.ts b/src/payload/common.ts
@@ -19,7 +19,7 @@ export interface Pagination {
   limit?: number;
 }
 
-export type PaginatedData<PayloadType> = {
+export interface PaginatedData<PayloadType> {
   data: PayloadType[];
   pagination: {after?: string; before?: string};
-};
+}