Skip to content
This repository has been archived by the owner on Apr 2, 2024. It is now read-only.

add ability to cancel a single order using the order id #283

Merged
merged 1 commit into from
Oct 18, 2020

Conversation

definitelycarter
Copy link
Contributor

  • Add ability to cancel an order using the order id.
  • Updated the jsdoc comment for cancelOpenOrders using the verbiage from the Coinbase API docs.

Fixes #260

@definitelycarter
Copy link
Contributor Author

I'll add a test for this new method.

@codecov-io
Copy link

codecov-io commented Oct 17, 2020

Codecov Report

Merging #283 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #283   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines          479       482    +3     
  Branches        29        29           
=========================================
+ Hits           479       482    +3     
Flag Coverage Δ
#unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/order/OrderAPI.ts 100.00% <100.00%> (ø)

@bennycode
Copy link
Owner

Hi @definitelycarter and thank you for your contribution. I will merge it and add the optional parameter product_id to fully map out this endoint.

Thank you also for the description update of cancelOpenOrders. 👍

@bennycode bennycode merged commit 98eb86e into bennycode:master Oct 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MIssing api functionality
3 participants