This repository has been archived by the owner on Apr 2, 2024. It is now read-only.
Add ticker_1000 ws channel #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjoelr
force-pushed
the
feature/ticker_1000-channel
branch
from
5258299
to
292ee1d
Compare
Codecov Report
@@ Coverage Diff @@
## main #655 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 19 19
Lines 508 509 +1
Branches 39 39
=========================================
+ Hits 508 509 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
@bennycode This is ready for review/merge. Thanks! |
|
Thank you and a happy 2022! 🎉 I am merging your PR now and I will release it in a bit. |
|
@bennycode Awesome. Thank you! Happy new year to you too! I can tell you've put a ton of thought and work into this SDK and it's much appreciated. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coinbase Pro uses a special version of the ticker channel named 'ticker_1000' which only provides a ticker message about every 5 seconds instead of as each tick happens. This can lighten the load on the client if it doesn't need every single ticker message. In this commit I'm adding that channel name.