Handle HTTP 429, rate limiting #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per the announcement on Discourse meta, global API rate limits have been introduced to the Discourse API. This change adds a new DiscourseRateLimitedError class and a retry mechanism on receipt of a 429. https://meta.discourse.org/t/global-rate-limits-in-discourse/78612 Closes: pydiscourse#11
|
Not sure if this will impact on this PR but they may change how the wait period is reported. |
|
Looks like a Retry-After header was added which could be used instead of checking the json for wait_seconds. |
|
@bennylope Are there any changes you'd like to see here or are you willing to merge? |
|
@bennylope any plans to merge this ? Retrying based on API throttle would be great for me! |
|
Please merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the announcement on Discourse meta, global API rate limits have been
introduced to the Discourse API.
This change adds a new DiscourseRateLimitedError class and a retry mechanism on
receipt of a 429.
https://meta.discourse.org/t/global-rate-limits-in-discourse/78612
Closes: #11
I do have one question: Should the 'settings' (retry_{count,backof}) be defined somewhere easier to change?