add watch_topic

[glanzel]

Summary of changes

adds api call for: user gets notifications about a topic.

Checklist

• Changes represent a discrete update
• Commit messages are meaningful and descriptive
• Changeset does not include any extraneous changes unrelated to the discrete change

[bennylope]

__init__.py renamed to ahaha__init__.py?

[glanzel]

sorry for the one useless commit. I just didn't excpected the pull request gets resolved right after i tried out some stuff . Now everything is back in place.

[glanzel]

I just wanted to clarify that my commit is ready for pulling since 2020/05/14.
I think it is a usefull commit as it adds additional features. I needed this change for my work and would like to see it in your respository. As I am new to use Pull request in github please feel free to give me hints if something is wrong with my request.

[bennylope]

The feature would be a nice addition, but there's some unnecessary commits and changes here.

I started to clean that up - which is not a big deal - but I'm confused about why the api_user is reset in the watch_topic method.

[bennylope]

?

[bennylope]

Why is this resetting the api_username?

[bennylope]

Why is this resetting the api_username? That's the username to connect to the API with, and it's already set when creating the client instance. Changing it here would presumably result in authentication errors trying to make requests to the Discourse API...

[bennylope]

Closing this, if requested changes are made will re-open.

[glanzel]

yes sure, i am very sorry that my communication was so bad. I fact the resetting the api_username is need for the functionality and works if the api_user is system (dont know why) but dont works if the api_user is some else. So it's probably nothing for the official pydiscourse like that. Unfortunately i could figure out how to do this in a better way with the given discourse api so i lost my motivation. Sorry for the additional work for you. Greeting grischan Am Mi., 11. Nov. 2020 um 00:37 Uhr schrieb Ben Lopatin < notifications@github.com>:

…

Closed #31 <#31>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#31 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AASLTZFDNNYRLSVZPCSSYCDSPHFE5ANCNFSM4MHJEI7Q> .