Skip to content

Commit

Permalink
feat: migrated from jshint to eslint
Browse files Browse the repository at this point in the history
  • Loading branch information
bennymeg committed Mar 14, 2021
1 parent 4a2908f commit a7297ff
Show file tree
Hide file tree
Showing 7 changed files with 1,014 additions and 723 deletions.
3 changes: 3 additions & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
node_modules/
scripts/
build/
14 changes: 14 additions & 0 deletions .eslintrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
{
"root": true,
"parser": "@typescript-eslint/parser",
"plugins": [
"@typescript-eslint",
"jest"
],
"extends": [
"eslint:recommended",
"plugin:@typescript-eslint/eslint-recommended",
"plugin:@typescript-eslint/recommended"
],
"rules": {}
}
4 changes: 0 additions & 4 deletions .jshintrc

This file was deleted.

6 changes: 3 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,14 @@
- `git clone https://github.com/bennymeg/nx-electron.git`
- link the forked project:
- `cd nx-electron && npm link`
- make a change
- make your desired changes to your fork of the nx-electron repository
- create a new test project and link your forked project into it:
- `npx create-nx-workspace nx-electron-test`
- `cd nx-electron-test && npm link nx-electron`
- `nx g nx-electron:app <electron-test-app-name> --frontendProject=<frontend-test-app-name>`
- test your changes (e.g. serving, building, packaging, making, etc..)
- test the forked project and make sure it completes without any warnnings
- test the forked project and make sure it completes without any warnings
- `npm run test`
- lint the forked project and make sure it completes without any warnnings
- lint the forked project and make sure it completes without any warnings
- `npm run lint`
- open a pull request

0 comments on commit a7297ff

Please sign in to comment.