Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Relative path of main.preload was being passed leading to a webpack ERROR #277

Merged
merged 1 commit into from
Feb 17, 2024

Conversation

arkad-cm
Copy link
Contributor

@arkad-cm arkad-cm commented Jan 28, 2024

BEFORE

> nx run mailmagnet-app:build

Dirent {
  name: 'main.preload.ts',
  path: 'mailmagnet/app/src/app/api',
  [Symbol(type)]: 1
} {
  entry: {
    main: [
      '/Users/arkadevbanerjee/Desktop/Development/ui-remote/mailmagnet/app/src/main.ts'
    ],
    'main.preload': 'mailmagnet/app/src/app/api/main.preload.ts'
  },
  devtool: 'source-map',
  mode: 'development',
  output: {
    path: '/Users/arkadevbanerjee/Desktop/Development/ui-remote/dist/mailmagnet/app',
    filename: [Function: filename],
    hashFunction: 'xxhash64',
    pathinfo: false,
    libraryTarget: 'commonjs'
  },
  module: { rules: [ [Object] ] },
  resolve: {
    extensions: [ '.ts', '.tsx', '.mjs', '.js', '.jsx' ],
    alias: {},
    plugins: [ [TsconfigPathsPlugin] ],
    mainFields: [ 'es2015', 'module', 'main' ]
  },
  performance: { hints: false },
  plugins: [
    ForkTsCheckerWebpackPlugin { options: [Object] },
    DefinePlugin { definitions: [Object] },
    CopyPlugin { patterns: [Array], options: {} }
  ],
  watch: false,
  watchOptions: { poll: undefined },
  stats: 'normal',
  target: 'electron-main',
  node: false,
  externals: [ [Function (anonymous)] ]
}
asset main.js 11.9 KiB [compared for emit] (name: main) 1 related asset
asset main.preload.js 99 bytes [emitted] (name: main.preload)
asset assets/gitkeep_tmpl_ 13 bytes [compared for emit] [from: mailmagnet/app/src/assets/gitkeep_tmpl_] [copied]
cacheable modules 9.05 KiB
  modules by path ./mailmagnet/app/src/app/ 7.83 KiB
    modules by path ./mailmagnet/app/src/app/events/*.ts 2.97 KiB
      ./mailmagnet/app/src/app/events/squirrel.events.ts 2.2 KiB [built] [code generated]
      ./mailmagnet/app/src/app/events/electron.events.ts 791 bytes [built] [code generated]
    modules by path ./mailmagnet/app/src/app/*.ts 4.85 KiB
      ./mailmagnet/app/src/app/app.ts 4.41 KiB [built] [code generated]
      ./mailmagnet/app/src/app/constants.ts 449 bytes [built] [code generated]
  ./mailmagnet/app/src/main.ts 1.04 KiB [built] [code generated]
  ./mailmagnet/app/src/environments/environment.ts 189 bytes [built] [code generated]
external "electron" 42 bytes [built] [code generated]
external "child_process" 42 bytes [built] [code generated]
external "path" 42 bytes [built] [code generated]
external "url" 42 bytes [built] [code generated]

ERROR in main.preload
Module not found: Error: Can't resolve 'mailmagnet/app/src/app/api/main.preload.ts' in '/Users/arkadevbanerjee/Desktop/Development/ui-remote'
Did you mean './mailmagnet/app/src/app/api/main.preload.ts'?
Requests that should resolve in the current directory need to start with './'.
Requests that start with a name are treated as module requests and resolve within module directories (node_modules).
If changing the source code is not an option there is also a resolve options called 'preferRelative' which tries to resolve these kind of requests in the current directory too.
resolve 'mailmagnet/app/src/app/api/main.preload.ts' in '/Users/arkadevbanerjee/Desktop/Development/ui-remote'
  Parsed request is a module
  using description file: /Users/arkadevbanerjee/Desktop/Development/ui-remote/package.json (relative path: .)
    resolve as module
      looking for modules in /Users/arkadevbanerjee/Desktop/Development/ui-remote/node_modules
        /Users/arkadevbanerjee/Desktop/Development/ui-remote/node_modules/mailmagnet doesn't exist
      /Users/arkadevbanerjee/Desktop/Development/node_modules doesn't exist or is not a directory
      /Users/arkadevbanerjee/Desktop/node_modules doesn't exist or is not a directory
      /Users/arkadevbanerjee/node_modules doesn't exist or is not a directory
      /Users/node_modules doesn't exist or is not a directory
      /node_modules doesn't exist or is not a directory

webpack 5.90.0 compiled with 1 error in 897 ms

 ———————————————————————————————————————————————————————————————————————————————————————————

 >  NX   Ran target build for project mailmagnet-app (2s)
 
    ✖    1/1 failed
    ✔    0/1 succeeded [0 read from cache]

AFTER

> nx run mailmagnet-app:build

Dirent {
  name: 'main.preload.ts',
  path: 'mailmagnet/app/src/app/api',
  [Symbol(type)]: 1
} {
  entry: {
    main: [
      '/Users/arkadevbanerjee/Desktop/Development/ui-remote/mailmagnet/app/src/main.ts'
    ],
    'main.preload': '/Users/arkadevbanerjee/Desktop/Development/ui-remote/mailmagnet/app/src/app/api/main.preload.ts'
  },
  devtool: 'source-map',
  mode: 'development',
  output: {
    path: '/Users/arkadevbanerjee/Desktop/Development/ui-remote/dist/mailmagnet/app',
    filename: [Function: filename],
    hashFunction: 'xxhash64',
    pathinfo: false,
    libraryTarget: 'commonjs'
  },
  module: { rules: [ [Object] ] },
  resolve: {
    extensions: [ '.ts', '.tsx', '.mjs', '.js', '.jsx' ],
    alias: {},
    plugins: [ [TsconfigPathsPlugin] ],
    mainFields: [ 'es2015', 'module', 'main' ]
  },
  performance: { hints: false },
  plugins: [
    ForkTsCheckerWebpackPlugin { options: [Object] },
    DefinePlugin { definitions: [Object] },
    CopyPlugin { patterns: [Array], options: {} }
  ],
  watch: false,
  watchOptions: { poll: undefined },
  stats: 'normal',
  target: 'electron-main',
  node: false,
  externals: [ [Function (anonymous)] ]
}
asset main.js 11.9 KiB [compared for emit] (name: main) 1 related asset
asset main.preload.js 1.96 KiB [emitted] (name: main.preload) 1 related asset
asset assets/gitkeep_tmpl_ 13 bytes [compared for emit] [from: mailmagnet/app/src/assets/gitkeep_tmpl_] [copied]
cacheable modules 9.33 KiB
  modules by path ./mailmagnet/app/src/app/ 8.11 KiB
    modules by path ./mailmagnet/app/src/app/events/*.ts 2.97 KiB
      ./mailmagnet/app/src/app/events/squirrel.events.ts 2.2 KiB [built] [code generated]
      ./mailmagnet/app/src/app/events/electron.events.ts 791 bytes [built] [code generated]
    modules by path ./mailmagnet/app/src/app/*.ts 4.85 KiB
      ./mailmagnet/app/src/app/app.ts 4.41 KiB [built] [code generated]
      ./mailmagnet/app/src/app/constants.ts 449 bytes [built] [code generated]
    ./mailmagnet/app/src/app/api/main.preload.ts 285 bytes [built] [code generated]
  ./mailmagnet/app/src/main.ts 1.04 KiB [built] [code generated]
  ./mailmagnet/app/src/environments/environment.ts 189 bytes [built] [code generated]
external "electron" 42 bytes [built] [code generated]
external "child_process" 42 bytes [built] [code generated]
external "path" 42 bytes [built] [code generated]
external "url" 42 bytes [built] [code generated]
webpack 5.90.0 compiled successfully in 901 ms

 ———————————————————————————————————————————————————————————————————————————————————————————

 >  NX   Successfully ran target build for project mailmagnet-app (2s)

@arkad-cm
Copy link
Contributor Author

'main.preload': 'mailmagnet/app/src/app/api/main.preload.ts'

was relative before and was breaking.
After changing join to resolve it is now absolute

/Users/arkadevbanerjee/Desktop/Development/ui-remote/mailmagnet/app/src/app/api/main.preload.ts

And after this the error gets fixed!

@arkad-cm arkad-cm changed the title Update executor.ts [FIX] Relative path of main.preload was being passed leading to a webpack ERROR Jan 28, 2024
@bennymeg bennymeg merged commit 9e9a6db into bennymeg:master Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants