feat: deprecated uglify in favor of cssnano or cleanCSS #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0d56f54 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bennypowers
force-pushed
the
feat/ts/clean-css
branch
from
75b8450
to
e64dbcf
Compare
|
alright so at this point, i'm using postcss's hidden "debug sync mode" to handle css nesting, then passing that through to cleanCss, so long as the user requests it. This sucks, and i would really rather not have separate APIs for typescript and everyone else, but AFAICT there's no way to run async code in a TS transformer visitor, so 💩 |
bennypowers
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See tests. if i throw the minified css, i get the right value as an exception, but if i return it, i get the unminified css in the result 🤬
This also kinda sucks because every other plugin uses cssnano, but typescript-transforms can't because all typescript transform functions have to be sync, and postcss things that's lame.
Closes #43