-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition of SM based Stocks #31
Comments
Hi Saurabh, The bhavcopy doesn't include SME stocks, they are released as a separate report (SME- Bhavcopy file). See NSE series legend I'm not keen on adding any new data source to this repo. It would require maintaining additional data i.e corporate actions for all the years, bhavcopy reports etc. This is required to recreate the data if due to unforeseen errors the data is corrupted. The feature itself is trivial to implement since a lot of the code is already in place. I can create a separate repo (just the code) if you strongly need it. But i will need time. Currently i am working on improving and adding new features to |
Thanks for the reply. Don't create new code just for this. Data is already coming in Bhav copy. saurabhgarg@Saurabhs-MacBook-Pro 2023 % grep ',SM,' cm08AUG2023bhav.csv Check this URL. Thanks |
Ah! I didn't notice it. This makes it easier. But i will still maintain a separate repo for this until the code is stable and runs without any significant issues. I can always merge the code back into this repo if required. The code changes are minimal. But i will need time, perhaps by month end i can start work on this. I will create a blank repo Let me know your thoughts |
Sure Benny, its fine. |
Let me check on the same and get back to you. |
I have opened a new issue https://github.com/BennyThadikaran/eod2-sme/issues/1 in eod2-sme. We can continue the discussion there. You can close this issue. |
Sure. Thanks |
Hello Benny,
It just a suggestion, you are filtering the EQ, BE and BZ. It does not have SME based stocks.
Can you include the same in the code.
Thanks
Saurabh
The text was updated successfully, but these errors were encountered: