Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
make sure we return the correct error with the last traceback.
fix #630
- Loading branch information
Showing
2 changed files
with
11 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0e4d9f0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error we got was actually from sync.py around line 54. You may want to do the same thing there. I don't think this change will fix anybody's problem because it's not really a bug in your code, but it should let you point them in a different direction.
I think our problem might be that we tell the client we're sending them UTF-8 and then we send them something different. But that is still a guess.
0e4d9f0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pdodde I think this is intended to fix the problem you describe.
This is the likely point at which the exception was re-raised. It is caught around line 54. The problem is that the raise call is raising last error, not the original error, which is why we cannot see what really went wrong.
At least, that's the hope.