Merge pull request #2731 from benoitc/daemonize-dev-null-stdin-inheri…

…table Ensure fd 0 stdin </dev/null is always inheritable Fixed #2727 .
benoitc · Feb 6, 2022 · 238de4e · 238de4e
2 parents e5a9715 + 230cd03
commit 238de4e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/THANKS b/THANKS
@@ -109,6 +109,7 @@ Kyle Mulka <repalviglator@yahoo.com>
 Lars Hansson <romabysen@gmail.com>
 Leonardo Santagada <santagada@gmail.com>
 Levi Gross <levi@levigross.com>
+licunlong <shenxiaogll@163.com>
 Łukasz Kucharski <lkucharski@leon.pl>
 Mahmoud Hashemi <mahmoudrhashemi@gmail.com>
 Malthe Borch <mborch@gmail.com>

diff --git a/gunicorn/util.py b/gunicorn/util.py
@@ -486,7 +486,10 @@ def daemonize(enable_stdio_inheritance=False):
             closerange(0, 3)
 
             fd_null = os.open(REDIRECT_TO, os.O_RDWR)
+            # PEP 446, make fd for /dev/null inheritable
+            os.set_inheritable(fd_null, True)
 
+            # expect fd_null to be always 0 here, but in-case not ...
             if fd_null != 0:
                 os.dup2(fd_null, 0)