-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This change optimize the sync worker when we only have to listen on one interface. While I'm here, I fixed a long and unnoticed outstanding issue when we were accepting on multiple interfaces (wonder if someone really use it), at some point soe interfaces were skipped.
- Loading branch information
Showing
1 changed file
with
72 additions
and
41 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4c601ce
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you explain your commit? Thanks
4c601ce
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's actually pretty simple, it remove the unnecessary calls for the simple case when gunicorn is listening on only one interface. T
he multiple interface case was bugged because we were only exhausting ready sockets and continue until it fails. While at first ready were all sockets, once they come from the select, they are only the readable sockets and we were excluding from time to times some interfaces for a long time.